Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PInvoke warnings fixes for OOB assemblies #54355

Closed
wants to merge 1 commit into from
Closed

PInvoke warnings fixes for OOB assemblies #54355

wants to merge 1 commit into from

Conversation

LakshanF
Copy link
Member

The PInvoke analysis changes cause the trimmer warnings to move to the call sites. Once the change gets merged to the runtime repo, there will be new warnings from building the OOB assemblies. This PR has changes that will fix the warnings and adding as a draft PR to expedite the trimmer integration when that happen

@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Jun 17, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Jun 17, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

The PInvoke analysis changes cause the trimmer warnings to move to the call sites. Once the change gets merged to the runtime repo, there will be new warnings from building the OOB assemblies. This PR has changes that will fix the warnings and adding as a draft PR to expedite the trimmer integration when that happen

Author: LakshanF
Assignees: -
Labels:

linkable-framework
Milestone: -

@LakshanF LakshanF marked this pull request as draft June 17, 2021 19:20
@LakshanF LakshanF mentioned this pull request Jun 17, 2021
Merged
@akoeplinger
Copy link
Member

I cherry-picked your commit to #54218 where the linker update is happening :)

@ghost ghost closed this Jul 18, 2021
@ghost
Copy link

ghost commented Jul 18, 2021

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2021
@LakshanF LakshanF deleted the PInvokeWrnFix branch May 10, 2022 13:21
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LakshanF @akoeplinger